diff --git a/project.clj b/project.clj index b7e1718..d3d74b1 100644 --- a/project.clj +++ b/project.clj @@ -49,7 +49,8 @@ :bikeshed {:plugins - [[lein-bikeshed "0.5.2"]]} + [[lein-bikeshed "0.5.2" + :exclusions [org.clojure/tools.namespace]]]} :check-namespace-decls {:plugins [[lein-check-namespace-decls "1.0.2"]] diff --git a/test/metabase/connection_pool_test.clj b/test/metabase/connection_pool_test.clj index 4306977..1afa610 100644 --- a/test/metabase/connection_pool_test.clj +++ b/test/metabase/connection_pool_test.clj @@ -6,9 +6,14 @@ {:classname "org.h2.Driver", :subprotocol "h2", :subname "mem:db"}) (t/deftest properties-test - (t/is (= "acquireIncrement -> 1" - (->> (connection-pool/connection-pool-spec spec {"acquireIncrement" 1}) - :datasource - str - (re-find #"acquireIncrement -> \d"))) - "Options passed in to `connection-pool-spec` should get parsed correctly")) + (t/testing "Options passed in to `connection-pool-spec` should get parsed correctly" + (let [description (-> (connection-pool/connection-pool-spec spec {"acquireIncrement" 1 + "testConnectionOnCheckin" true}) + :datasource + str)] + (t/is (= "acquireIncrement -> 1" + (re-find #"acquireIncrement -> \d" description)) + "numeric options should get converted correctly") + (t/is (= "testConnectionOnCheckin -> true" + (re-find #"testConnectionOnCheckin -> \w+" description)) + "boolean options should get converted correctly"))))