From e9d172d4a7ba3af37be5ef8234cdba11fe1bfb8c Mon Sep 17 00:00:00 2001 From: Jimmi Dyson Date: Wed, 22 Feb 2023 17:28:01 +0000 Subject: [PATCH] fix: Do not upx pack darwin binaries (#342) --- make/upx.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/make/upx.mk b/make/upx.mk index 2b6e5596..f32aa9c2 100644 --- a/make/upx.mk +++ b/make/upx.mk @@ -8,9 +8,8 @@ upx: UPX_REAL_TARGET := $(addsuffix $(if $(filter $(GOOS),windows),.exe),$(basen ifneq ($(SKIP_UPX),true) ifeq ($(GOOS)/$(GOARCH),windows/arm64) upx: ; $(info $(M) skipping packing $(UPX_REAL_TARGET) - $(GOOS)/$(GOARCH) is not yet supported by upx) -# TODO Remove once upx 4.0.2 is released -else ifeq ($(GOOS)/$(GOARCH),darwin/arm64) -upx: ; $(info $(M) skipping packing $(UPX_REAL_TARGET) - $(GOOS)/$(GOARCH) has a bug in packing - https://github.com/upx/upx/issues/628 - should be fixed in 4.0.2) +else ifeq ($(GOOS),darwin) +upx: ; $(info $(M) skipping packing $(UPX_REAL_TARGET) - $(GOOS) has a bug in packing especially on Ventura - https://github.com/upx/upx/issues/612) else upx: install-tool.upx upx: ## Pack executable using upx