Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated publishing of Meshery core definitions #60

Open
leecalcote opened this issue Mar 15, 2024 · 8 comments
Open

Automated publishing of Meshery core definitions #60

leecalcote opened this issue Mar 15, 2024 · 8 comments
Labels
issue/willfix This issue will be worked on models

Comments

@leecalcote
Copy link
Member

          Is there a conjoining PR in meshery/meshery to delete these definitions?

Is the registry model generator configured to source components from meshery/schemas?

Or is there workflow that needs to populate meshery/meshery with updates to these schemas? // @MUzairS15

Originally posted by @leecalcote in #58 (comment)

@leecalcote
Copy link
Member Author

leecalcote commented Mar 15, 2024

Is this needed? #40 // @Yashsharma1911

@leecalcote
Copy link
Member Author

@Yashsharma1911 @MUzairS15 has this been implemented?

@leecalcote
Copy link
Member Author

If v1beta1 of components is ready to release, new definitions in #73 will have already been created and pushed, correct?

@MUzairS15
Copy link

Yes we are referencing defs in schemas repository and automatically sync those to meshery repo.

Release of meshery will also necessitate release of schemas with new v1beta1 defs. Those will be updated.

@leecalcote
Copy link
Member Author

Thanks for confirming. I tend to think of the direction of our development differently. I think that being schema to definition to declaration to instance is the way that our development should go.

@MUzairS15
Copy link

MUzairS15 commented May 6, 2024

Yes I agree with the order of development. Because for core models are curated by us, we need to define it somewhere, instead of skipping the first step (starting from defs) we can start from the schema.
We will need to define kind for these comps (similarly to that of CRD)

Copy link

stale bot commented Jun 15, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jun 15, 2024
Copy link

stale bot commented Jun 26, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Jun 26, 2024
@leecalcote leecalcote reopened this Jun 26, 2024
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jun 26, 2024
@leecalcote leecalcote added the issue/willfix This issue will be worked on label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/willfix This issue will be worked on models
Projects
None yet
Development

No branches or pull requests

2 participants