diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go index dcaedf2d..8fb2d0d9 100644 --- a/pkg/metrics/metrics.go +++ b/pkg/metrics/metrics.go @@ -23,12 +23,12 @@ var ( ProposedCPURequest = prometheus.NewGaugeVec(prometheus.GaugeOpts{ Name: "proposed_cpu_request", - Help: "recommended resource request that tortoises propose", + Help: "recommended cpu request (millicore) that tortoises propose", }, []string{"tortoise_name", "namespace", "container_name"}) ProposedMemoryRequest = prometheus.NewGaugeVec(prometheus.GaugeOpts{ Name: "proposed_memory_request", - Help: "recommended resource request that tortoises propose", + Help: "recommended memory request (millibyte) that tortoises propose", }, []string{"tortoise_name", "namespace", "container_name"}) ) diff --git a/pkg/vpa/service.go b/pkg/vpa/service.go index fe96ba41..3d20070d 100644 --- a/pkg/vpa/service.go +++ b/pkg/vpa/service.go @@ -212,7 +212,7 @@ func (c *Service) UpdateVPAFromTortoiseRecommendation(ctx context.Context, torto metrics.ProposedCPURequest.WithLabelValues(tortoise.Name, tortoise.Namespace, r.ContainerName).Set(float64(value.MilliValue())) } if resourcename == corev1.ResourceMemory { - metrics.ProposedCPURequest.WithLabelValues(tortoise.Name, tortoise.Namespace, r.ContainerName).Set(float64(value.MilliValue())) + metrics.ProposedMemoryRequest.WithLabelValues(tortoise.Name, tortoise.Namespace, r.ContainerName).Set(float64(value.MilliValue())) } } metricsRecorded = true