Catch PermissionDenied from create_subscription and continue to try t… #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o update the existing subscription if necessary
dolfandringa
requested review from
daniel-ruiz,
EmilioCarrion and
AdamjGoddard
as code owners
jonasae
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What?
Catch PermissionDenied and continue with updating the existing subscription if necessary.
🤔 Why?
If the subscription already exists (because it was pre-created) and the service account does not have roles/pubsub.editor permission at the project level, but does have role/pubsub.subscriber on the topic and subscription, the user is not allowed to create a subscription, and the current code will result in an error. Continuing from that error is totally fine though, if the user does have permission to consume the subscription, and update it (if necessary)
🔗 Related issue
Closes #262