Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite #8

Closed
bglusman opened this issue Aug 18, 2016 · 3 comments
Closed

Test suite #8

bglusman opened this issue Aug 18, 2016 · 3 comments

Comments

@bglusman
Copy link

bglusman commented Aug 18, 2016

@sschepens hey so I was looking at maybe starting on the config extension for #7 and thought I'd start by reviewing existing tests, maybe try and even start TDD with a new failing test (I'm not great at TDD but like to try now and then), but I'm not seeing any tests in the repo... any chance you just didn't commit them for some reason? If not, maybe I can adapt some of shoryuken's tests and get a suite running on Travis or something, seems like we'd like at least decent test coverage going forward to enable safe releases.

@bglusman
Copy link
Author

@sschepens Ping? We may just fork and do this ourselves either way but definitely appreciate your feedback and buy in! Thanks!

@sschepens
Copy link
Collaborator

@bglusman sorry for the delay, been busy. When I started toiler we were in a rush with a project and needed a quick replacement to shoryuken, that's why I never got to write any tests, I'm dedicating some of my free time to write some.
If you feel like contributing too it would be great!
I don't think much of Shrouyken's tests can be ported, a lot has changed since, maybe Cli remains somehow similar.

@bglusman
Copy link
Author

Since this is merged in now with at least some tests closing this, thanks @sschepens !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants