Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popcornjs.org demo video broken #52

Open
menismu opened this issue Apr 4, 2018 · 1 comment
Open

popcornjs.org demo video broken #52

menismu opened this issue Apr 4, 2018 · 1 comment

Comments

@menismu
Copy link
Owner

menismu commented Apr 4, 2018

Issue reported: mozilla#455
Reported by: @minshallj

After the commit that removed twitter was merged (mozilla#332), the popcornjs.org demo video has been broken. At 29 seconds (Will Ferrell dancing) all content stops appearing next to the video. Google developer tools report this error:

Uncaught TypeError: Popcorn(...).listen(...).footnote(...).footnote(...).image(...).googlemap(...).googlemap(...).flickr(...).twitter is not a function
I don't really know anything about popcornjs, but wherever the twitter stuff went should be included along with http://popcornjs.org/code/dist/popcorn-complete.js on line 158 in the source for popcornjs.org

@vintprox
Copy link

Last link seems broken as many examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants