You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I understand that this might be a continuation to mozilla#430 but I felt this was a separate issue to do with the same section of code.
I am happy to contribute a pull request to fix the issue along with mozilla#430 but would like to discuss workflow here first.
Given the use of the following code, the start time is ignored.
document.addEventListener("DOMContentLoaded", function() {
var popcorn = Popcorn.smart("#video", "http://www.youtube.com/watch?v=eTKs27KcL00&t=10s");
}, false);
In the middle of onFirstPlay() there is a line that resets the video back to 0 which causes this to occur.
Suggested changes:
onFirstPlay() makes use of the start or t player variables instead of always going to 0.
onFirstPlay() should be triggered if player.seekTo() is going to be triggered or if preload() is required.
onFirstPlay() should not pause if autoplay is true.
The text was updated successfully, but these errors were encountered:
Issue reported: mozilla#452
Reported by: @cvcmatthewmorgan
I understand that this might be a continuation to mozilla#430 but I felt this was a separate issue to do with the same section of code.
I am happy to contribute a pull request to fix the issue along with mozilla#430 but would like to discuss workflow here first.
Given the use of the following code, the start time is ignored.
document.addEventListener("DOMContentLoaded", function() {
var popcorn = Popcorn.smart("#video", "http://www.youtube.com/watch?v=eTKs27KcL00&t=10s");
}, false);
In the middle of onFirstPlay() there is a line that resets the video back to 0 which causes this to occur.
Suggested changes:
onFirstPlay() makes use of the start or t player variables instead of always going to 0.
onFirstPlay() should be triggered if player.seekTo() is going to be triggered or if preload() is required.
onFirstPlay() should not pause if autoplay is true.
The text was updated successfully, but these errors were encountered: