Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEN-7672: Update information regarding "out of the box" Update Modules #2497

Merged

Conversation

lluiscampos
Copy link
Contributor

@lluiscampos lluiscampos commented Nov 26, 2024

The modules are installed by default. It has not been checked since when this documentation is out of date, but all currently supported client versions behave this way.

Missing from commit 1cae3d9

Copy link
Contributor

@estenberg estenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would reword a bit if I interpreted correctly

Mender comes with one Update Module to perform full rootfs updates:
* rootfs-image

Additionally, there are some Update Modules available out of the box. These are:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would say

In addition, these Update Modules available for install:

  • directory
  • single-file

However, they are not enabled by default...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just wasn't clear what "out of the box" means in this context.

I interpreted it as "rootfs-image" is always installed (that I would call out of the box, but don't have to phrase it like that) while the others can easily be installed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "out of the box" was already there. But I will remove it now 👍

The modules are installed by default. It has not been checked since when
this documentation is out of date, but all currently supported client
versions behave this way.

Missing from commit 1cae3d9

Ticket: MEN-7672

Signed-off-by: Lluis Campos <[email protected]>
@lluiscampos
Copy link
Contributor Author

@estenberg I investigated further to realize that the documentation was wrong: these modules are installed by default. Please see the rework now (and the rewording of "out of the box" 😉 )

@lluiscampos
Copy link
Contributor Author

Pinging also @TheMeaningfulEngineer and @danielskinstad for a sanity check on the yocto syntax 🧐

Copy link
Contributor

@estenberg estenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clear!

@lluiscampos lluiscampos merged commit 6c66701 into mendersoftware:master Nov 28, 2024
1 check passed
@lluiscampos lluiscampos deleted the follow-up-update-modules branch November 28, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants