feat: add skip-images flag feature #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging these commits will result in the following changelog entries: Changelogsapp-update-module (master)New changes in app-update-module since master: Features
|
This commit is adding the skip-images flag to the app-gen script, allowing the artifact creation to ignore image inclusion. The app script will hand over the responsibility of pulling images to the orchestrator. Changelog: Added support for skipping image inclusion in artifact. Ticket: None Signed-off-by: DamKas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It would be very usefull having the possibility to skip including images. That means give to docker compose the responsibility to pull the required images through the network directly from the target device.
This fix modifies the metadata:
If the skip-images flag is set, the metadata will include
images_urlsbut not theimagesshas.When the artifact is installed on the target, the app script will look for the
images.tar.gzfile but since it is not included in the artifact, it will not load any image.The
images_urlsis used for the clean_up function.https://hub.mender.io/t/suggestion-add-a-skip-images-option-to-app-update-module/7268