Add CLI #14
Merged
Add CLI #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthez
requested review from
FelonEkonom and
Noarkhh
and removed request for
varsill and
FelonEkonom
varsill
reviewed
Aug 12, 2024
Comment on lines
+40
to
+52
| |> Enum.drop_while(&(&1 != type)) | ||
| |> Enum.drop(1) | ||
| |> Enum.take_while(&(&1 not in [:i, :o])) | ||
| |> case do | ||
| [value] -> value | ||
| [_h | _t] = values -> List.to_tuple(values) |
There was a problem hiding this comment.
it's fine for now, but I think we finally gonna need to use something like: https://hexdocs.pm/elixir/1.12.3/OptionParser.html or https://www.erlang.org/doc/apps/stdlib/argparse.html
There was a problem hiding this comment.
Good point. Currently, the API is not parsable by the OptionParser AFAIK - for example, we'd have to have boombox --i input.mp4 instead of boombox -i input.mp4. Maybe we should adjust to that, but that would require more thinking ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9
This PR allows building boombox as a standalone binary and adds a CLI API to call that binary. The API translates to the Elixir API in the following way:
-valueis translated to atom:valueFor example,
is equivalent to:
I chose burrito for the building part, because it's the only tool I found that outputs a single binary and requires neither Erlang nor Elixir. When the binary is run for the first time, it extracts the release from itself, stores it under a common location in the system, and calls it. Subsequent runs only call the unpacked release. In our case, the problem is that the uncompressed release weighs over 1,5 GB, because of FFmpeg artifacts which are duplicated for each package that uses FFmpeg and take over 1,4 GB. Thus, building the release and the first run (unpacking) takes a longer while.