Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize gzip with github.com/klauspost/pgzip #193

Closed
wants to merge 6 commits into from
Closed

Parallelize gzip with github.com/klauspost/pgzip #193

wants to merge 6 commits into from

Conversation

isac322
Copy link

@isac322 isac322 commented Dec 1, 2021

Please read CONTRIBUTING.md for details on our code of conduct, and the process for submitting pull requests to us.

Fixes #94

Proposed Changes

Description

github.com/klauspost/pgzip is drop in replacement of compress/gzip and it achieve better performance via parallelizing compression.

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.

@isac322 isac322 changed the title Parallelize gzip with https://github.com/klauspost/pgzip Parallelize gzip with github.com/klauspost/pgzip Dec 1, 2021
@jimsheldon
Copy link

Thanks for the contribution! It looks like this branch needs to be rebased off master, can you please update your branch? Thanks

@isac322
Copy link
Author

isac322 commented Jan 4, 2022

@jimsheldon done!

Copy link
Contributor

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@kakkoyun
Copy link
Contributor

kakkoyun commented Mar 9, 2022

Leaving the decision to merge to @jimsheldon

@isac322 isac322 closed this May 4, 2022
@isac322 isac322 deleted the pgzip branch May 4, 2022 04:17
@kakkoyun
Copy link
Contributor

kakkoyun commented May 9, 2022

@isac322 Why did you close it? I think this could be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more archive formats
3 participants