Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private_key setting to target-snowflake--meltanolabs #1856

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

ReubenFrankel
Copy link
Contributor

@ReubenFrankel ReubenFrankel commented Sep 25, 2024

New private_key setting definition, as per this PR. Will require a new PyPI release.

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit 588b339
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/66f46b9936ca7a000864fcad
😎 Deploy Preview https://deploy-preview-1856--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@edgarrmondragon
Copy link
Collaborator

I made a PyPI release on the 20th, so I wonder it wasn't picked up by #1853 🤔

@edgarrmondragon
Copy link
Collaborator

Thanks!

@edgarrmondragon edgarrmondragon merged commit 12af7cc into meltano:main Sep 25, 2024
13 checks passed
@ReubenFrankel
Copy link
Contributor Author

Sorry, it actually didn't require a release for the private_key feature. Got confused with MeltanoLabs/target-snowflake#262.

@ReubenFrankel ReubenFrankel deleted the patch-1 branch October 4, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants