fix: Change kind of port in TicketSwap target-redshift to string
#1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
requested review from
sbalnojan,
tayloramurphy and
pnadolny13
as code owners
✅ Deploy Preview for meltano-hub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
edgarrmondragon
force-pushed
the
edgarrmondragon/fix/target-redshift--ticketswap--port-string
branch
from
0d93a05 to
60cccf3
Compare
edgarrmondragon
changed the title
port in Ticketswap target-redshift to stringport in TicketSwap target-redshift to string
pnadolny13
approved these changes
Apr 17, 2024
edgarrmondragon
deleted the
edgarrmondragon/fix/target-redshift--ticketswap--port-string
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setting in the target's codebase is declared as
string, but asintegerhere in the Hub metadata. This changes the latter.https://github.com/TicketSwap/target-redshift/blob/caee498660ccbf0025c82f54b7889c17516e59f5/target_redshift/target.py#L82-L90
@tobiascadee let me know if you'd prefer to change this in the target's original settings :)