Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

are there plans for scanline filters to melonds? #2217

Open
DaStar22 opened this issue Nov 24, 2024 · 8 comments
Open

are there plans for scanline filters to melonds? #2217

DaStar22 opened this issue Nov 24, 2024 · 8 comments

Comments

@DaStar22
Copy link

DaStar22 commented Nov 24, 2024

recently i started enjoying scanline filters on emulators and i wish it would be added to the plans of the future.

sending love.

ps: i couldn't poste this on requests and somehow i posted it here sorry.

@user18081972
Copy link

You could technically do this in the Melonds-DS retroarch core, using Retroarch's build in shader system. https://github.com/JesseTG/melonds-ds

@DaStar22
Copy link
Author

so i downloaded retroarch... tried it... didn't like it... i was yearning for something i found on pizzaboyGBA... maybe because i tried it on windows, too meny pixels? anyways, thanx you so much for replying.

@user18081972
Copy link

It would be cool if MelonDS would integrate Librashader:
https://github.com/SnowflakePowered/librashader

@DaStar22
Copy link
Author

It would be cool if MelonDS would integrate Librashader: https://github.com/SnowflakePowered/librashader

i mean at this point all emulators have filters option... maybe MDS devs are focusing on accuracy for the moment (the new OpenGL is amazing and far better on the 1.0 release) and it will be implemented in the future? hard to say...

@user18081972
Copy link

user18081972 commented Nov 26, 2024

Librashader says it supports various versions of OpenGL, and its sort-of a plug-and-play solution, in that you dont have to develop the shaders or whatever, just get it hooked into the rendering and it does the rest for you. And the dev of Librashader is very willing to help people out who run into issues in integrating it into their emulators.
So hopefully that makes it a low enough barrier that someone will look into it.
afbeelding

When comparing my DSi to my PC yesterday i noticed how oversaturated the colors look on PC. And using the Retroarch shader NDS-color.glsl really makes it look more accurate to the way it should look on a DSi screen. But I prefer not to use Retroarch cause its janky.

@DaStar22
Copy link
Author

Librashader says it supports various versions of OpenGL, and its sort-of a plug-and-play solution, in that you dont have to develop the shaders or whatever, just get it hooked into the rendering and it does the rest for you. And the dev of Librashader is very willing to help people out who run into issues in integrating it into their emulators. So hopefully that makes it a low enough barrier that someone will look into it. afbeelding

VERY interesting... thank you for explaining.

@SnowSquire
Copy link

SnowSquire commented Nov 28, 2024

you can use reshade with melonds in the meantime

@user18081972
Copy link

user18081972 commented Nov 28, 2024

Reshade can totally do some basic scanline filter, so that should be a decent solution for @DaStar22 's question.

I would love to have some good color correction to emulate the NDS' LCD-screen more accurately though, and sadly the NDS-Color.slang/glsl shader isnt available on Reshade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants