Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js__Js_xxx.t appears on type-errors and hovering #1154

Open
davesnx opened this issue Jul 19, 2024 · 0 comments
Open

Js__Js_xxx.t appears on type-errors and hovering #1154

davesnx opened this issue Jul 19, 2024 · 0 comments

Comments

@davesnx
Copy link
Member

davesnx commented Jul 19, 2024

Since we wrap melange.js there's an unfortunate side-effect of dune being wrapped by using a module name with __ like (Js__Js_date) for all modules inside Js like (js_date.ml).

It's very convenient to use wrapped modules when you don't want to expose a bunch of modules to the top-level, but since Js isn't meant to be opened at the top I would argue that it's better if we keep it unwrapped for the sake of having better error messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant