Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An opt-in way to warn on include #1045

Open
jchavarri opened this issue Jan 30, 2024 · 0 comments
Open

An opt-in way to warn on include #1045

jchavarri opened this issue Jan 30, 2024 · 0 comments

Comments

@jchavarri
Copy link
Member

Using include in melange builds can be problematic, as any definitions in the included modules get duplicated. If this happens inside a submodule, where all these definitions are put into a JS object, it can have an impact on bundle size, as bundlers won't be able to dead-code eliminate any of them.

Example

I wonder if there could be a way to optionally enable some warnings on melc when include is used, explaining this problem in detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant