From 245877143fb02ac45672cf2e0ec677ea2aa4b54f Mon Sep 17 00:00:00 2001 From: Tobias Werth Date: Thu, 23 Nov 2023 11:44:40 +0100 Subject: [PATCH] Fix order of judgings on submission page. Found while looking at #2191, see this comment: https://github.com/DOMjudge/domjudge/issues/2191#issuecomment-1824185818 Previously, we treated the start time as higher priority indicator than the judgingId for sorting the rows. For submissions that are queued we don't have a starttime yet, so they show up first. Now, the order is purely by judgingid. For one specific submission, the starttime of judgings should always be in order of their judgingid so this change should be a no-op otherwise. --- webapp/src/Controller/Jury/SubmissionController.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/webapp/src/Controller/Jury/SubmissionController.php b/webapp/src/Controller/Jury/SubmissionController.php index 406440daff..d92a3e281e 100644 --- a/webapp/src/Controller/Jury/SubmissionController.php +++ b/webapp/src/Controller/Jury/SubmissionController.php @@ -217,8 +217,7 @@ public function viewAction( ->setParameter('contest', $submission->getContest()) ->setParameter('submission', $submission) ->groupBy('j.judgingid') - ->orderBy('j.starttime') - ->addOrderBy('j.judgingid') + ->orderBy('j.judgingid') ->getQuery() ->getResult();