CV2-5726 don't use reload flag when running the server in the cloud #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGaffney
requested review from
computermacgyver and
skyemeedan
as code owners
skyemeedan
approved these changes
Nov 26, 2024
| @@ -1,10 +1,14 @@ | |||
| .PHONY: run run_http run_worker run_test | |||
| .PHONY: run run_http run_worker run_processor run_test | |||
There was a problem hiding this comment.
this change is just about the build order for make, right?
Makefile
Outdated
|
|
||
| run: | ||
| ./start_all.sh | ||
|
|
||
| run_http: | ||
| ifeq ($(filter $(DEPLOY_ENV),qa live),) | ||
| uvicorn main:app --host 0.0.0.0 --reload |
There was a problem hiding this comment.
the --reload flag is about reloading based on code monitoring right? Assuming uvicorn will still try to restart without the flag?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use
--reloadwhen we really shouldn't in production on Presto - it slows requests down and the server will, by definition, never reload.Reference: CV2-5726
How has this been tested?
Not tested locally, by definition, since this applies to prod
Are there any external dependencies?
None
Have you considered secure coding practices when writing this code?
None