From c7fcdb238ac661cd69019ad1789a207ff1e1876a Mon Sep 17 00:00:00 2001 From: Scott Hale Date: Mon, 30 Sep 2024 23:17:43 +0100 Subject: [PATCH] CV2-5387: no langid in healthcheck (#456) * no langid in healthcheck * Remove test related to langid in healthcheck --------- Co-authored-by: computermacgyver --- app/main/controller/healthcheck_controller.py | 14 +++++++------- app/test/test_healthcheck.py | 10 +++++----- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/app/main/controller/healthcheck_controller.py b/app/main/controller/healthcheck_controller.py index e5715458..9da4e2c1 100644 --- a/app/main/controller/healthcheck_controller.py +++ b/app/main/controller/healthcheck_controller.py @@ -19,7 +19,7 @@ def get(self): 'ELASTICSEARCH_SIMILARITY': False, 'REDIS': False, 'DATABASE': False, - 'LANGID': False + # 'LANGID': False } # Elasticsearch @@ -50,11 +50,11 @@ def get(self): except Exception as e: result['DATABASE'] = str(e) - # Langid - try: - class_ = getattr(importlib.import_module('app.main.lib.langid'), app.config['PROVIDER_LANGID'].title() + 'LangidProvider') - result['LANGID'] = class_.test() - except Exception as e: - result['LANGID'] = '%s: %s' % (app.config['PROVIDER_LANGID'].title() + 'LangidProvider', str(e)) + # # Langid + # try: + # class_ = getattr(importlib.import_module('app.main.lib.langid'), app.config['PROVIDER_LANGID'].title() + 'LangidProvider') + # result['LANGID'] = class_.test() + # except Exception as e: + # result['LANGID'] = '%s: %s' % (app.config['PROVIDER_LANGID'].title() + 'LangidProvider', str(e)) return { 'result': result }, 200 if all(x and type(x) == type(True) for x in result.values()) else 500 diff --git a/app/test/test_healthcheck.py b/app/test/test_healthcheck.py index d9d790cb..d06fd1e2 100644 --- a/app/test/test_healthcheck.py +++ b/app/test/test_healthcheck.py @@ -66,11 +66,11 @@ def test_healthcheck_api_with_bad_config(self): self.assertEqual('application/json', response.content_type) self.assertEqual(500, response.status_code) - def test_healthcheck_api_with_import_error(self): - with patch.dict('sys.modules', {'app.main.lib.langid': None}): - response = self.client.get('/healthcheck/') - self.assertEqual('application/json', response.content_type) - self.assertEqual(500, response.status_code) + # def test_healthcheck_api_with_import_error(self): + # with patch.dict('sys.modules', {'app.main.lib.langid': None}): + # response = self.client.get('/healthcheck/') + # self.assertEqual('application/json', response.content_type) + # self.assertEqual(500, response.status_code) if __name__ == '__main__': unittest.main()