Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Change logger warning to UserWarning and ignore some inconsequential test warnings #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

greglucas
Copy link
Collaborator

  • Emit UserWarning for more visible issues with XTCE definitions.
  • Filter out warnings emitted by the tests that aren't of interest to the tests themselves. Fix some element tree comparisons that had future warnings indicating an explicit check against "is None" was needed. (There are now zero warnings when running pytest)
  • Use the walrus operator for assignment to avoid duplicate lookups with element tree find calls. (There are probably more places that this could be helpful, but I just fixed the places with warnings)

closes #116

Checklist

  • Changes are fully implemented without dangling issues or TODO items
  • Deprecated/superseded code is removed or marked with deprecation warning
  • Current dependencies have been properly specified and old dependencies removed
  • New code/functionality has accompanying tests and any old tests have been updated to match any new assumptions
  • The changelog.md has been updated

…tial test warnings

Emit UserWarning for more visible issues with XTCE definitions.
Filter out warnings emitted by the tests that aren't of interest to
the tests themselves.
@greglucas greglucas requested a review from medley56 as a code owner December 16, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change logger warnings to UserWarning
1 participant