#382 - Change display and translations structure for criteria and concepts #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
michael-82
commented
Oct 22, 2024
michael-82
commented
- remove nested declaration from elastic search documents (seems to be unnecessary, but should be monitored)
- modify swagger file to match new responses
- adapt tests to the new structure
- Change responses to codeable concept and terminology replies to the new structure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #384 +/- ##
=============================================
+ Coverage 78.54% 78.80% +0.26%
- Complexity 556 559 +3
=============================================
Files 138 139 +1
Lines 2419 2449 +30
Branches 149 149
=============================================
+ Hits 1900 1930 +30
Misses 461 461
Partials 58 58 ☔ View full report in Codecov by Sentry. |
michael-82
force-pushed
the
feature/382-change-display-and-translations-structure-for-criteria-and-concepts
branch
from
57631fd to
77b8a15
Compare
michael-82
force-pushed
the
feature/382-change-display-and-translations-structure-for-criteria-and-concepts
branch
from
77b8a15 to
8c9c7db
Compare
…cepts - remove nested declaration from elastic search documents (seems to be unnecessary, but should be monitored) - modify swagger file to match new responses - adapt tests to the new structure - Change responses to codeable concept and terminology replies to the new structure
michael-82
force-pushed
the
feature/382-change-display-and-translations-structure-for-criteria-and-concepts
branch
from
8c9c7db to
d0bc23f
Compare
…cepts - change de-De to de and en-US to us for the elastic search related entries (the ones sent to the frontend are unchanged...might have to change as well)
…cepts - fix es files in tests
…cepts - modify elastic search tests in integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.