MBS-8982: Add card numbers #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing master GHA is not related to this PR |
fhuebler
reviewed
Nov 4, 2024
fhuebler
requested changes
Nov 10, 2024
| @@ -539,6 +546,9 @@ public static function execute(int $cmid, int $boardid, int $timestamp = 0, bool | |||
| 'attachments', | |||
| $card->id | |||
| ); | |||
| if ($common->usenumbers) { | |||
| $card->description = numberfilter::filter($card->description); | |||
There was a problem hiding this comment.
Gut wäre es, wenn der Filter auch über die Discussions läuft.
There was a problem hiding this comment.
Ich sehe es im Code, dass du den Filter hinzugefügt hast, für die Discussions. es funktioniert bei mir aber leider nicht.
fhuebler
reviewed
Nov 25, 2024
sh-csg
force-pushed
the
MBS-8982-Card-numbers
branch
from
0e87e42 to
49bda93
Compare
sh-csg
force-pushed
the
MBS-8982-Card-numbers
branch
from
f6915d3 to
f5ccc18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #31