Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fleet missions' code #91

Open
mdziekon opened this issue Mar 25, 2020 · 0 comments
Open

Refactor fleet missions' code #91

mdziekon opened this issue Mar 25, 2020 · 0 comments
Assignees
@mdziekon
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup

Comments

@mdziekon
Copy link
Owner

mdziekon commented Mar 25, 2020 •
edited
Loading

Summary

In fleet missions' code there's a great deal of code duplication and complexities that are not easily grasped. This code needs to be refactored.

This should also help with writing adjustments to the expeditions code (#90)

Background

TBD

Related issues or PRs:
@mdziekon mdziekon added the enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup label Mar 25, 2020
@mdziekon mdziekon self-assigned this Mar 25, 2020
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Create getKnownPillagableResourceKeys() helper
add1430
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Create Collections\without() utility
9a18a45
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Create Flights module and its first helper, calculateResourcesP…
08eeb09 
…illage()
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Rename pillage calculating function to better describe its nature
d35d237
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Improve namespacing for scripts
fa4c89f
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Include PHPUnit and create testing script
4b1af3a
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Write tests for the pillaging function
ea39768
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Add an alternative, calculateValuePrioritizedResourcesPillage()…
2c13572 
… util
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Write tests for calculateValuePrioritizedResourcesPillage()
751380d
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Run tests in CI pipelines
d59ddce
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Update PHP version to the newest supported one on CI
383cc1d
@mdziekon mdziekon mentioned this issue Mar 25, 2020
Merged
8 tasks
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Rename pillage calculating function to better describe its nature
32c5dfa
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Improve namespacing for scripts
a55b10f
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Include PHPUnit and create testing script
1efa708
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Write tests for the pillaging function
170447b
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Add an alternative, calculateValuePrioritizedResourcesPillage()…
fec73ca 
… util
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Write tests for calculateValuePrioritizedResourcesPillage()
2fac790
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Run tests in CI pipelines
f238b06
mdziekon added a commit that referenced this issue Mar 25, 2020
@mdziekon
GH-91 Update PHP version to the newest supported one on CI
49c0446
mdziekon added a commit that referenced this issue Mar 28, 2020
@mdziekon
GH-91 Calculate max pillage separately to allow better control
9a3b360
mdziekon added a commit that referenced this issue Mar 28, 2020
@mdziekon
GH-91 Use the new utility function to calculate raid's pillage
9096026
mdziekon added a commit that referenced this issue Mar 28, 2020
@mdziekon
GH-91 Use the new utility function to calculate moon destruction's pi…
24efa02 
…llage
mdziekon added a commit that referenced this issue Mar 28, 2020
@mdziekon
GH-91 Use the new utility function to calculate united raid's pillage
4e825da
mdziekon added a commit that referenced this issue Mar 28, 2020
@mdziekon
GH-91 Remove unused variable
db91623
mdziekon added a commit that referenced this issue Mar 28, 2020
@mdziekon
GH-91 Initialise maxResourcesPillage with zero-valued entries
b668b7f
mdziekon added a commit that referenced this issue Mar 29, 2020
@mdziekon
GH-91 Implement getKnownDebrisRecoverableResourceKeys()
1460b38
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
[GH-91] Remove old-style array ctors
471d2b5
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
[GH-91] Move ship input rendering to a component
3fd70aa
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
[GH-91] Deduplicate ship input rendering for defs
a33e500
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
[GH-91] Use better name for element id
ab878d9
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
[GH-91] Use component in defs as well
e2b13a6
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
[GH-91] Use existing util to determine if def is rocket
b0fdef7
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
[GH-91] Move tech input rendering to a component
8cab007
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
[GH-91] Move morale input rendering to a component
523bfe7
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Use existing combat report factory
ee2d6b9
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Overall loop code cleanup
1fb04a1
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Use existing helper to determine if element is ship
c4de36a
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Localise planet name
c65cf83
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Simplify cleanup code
8a311a7
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Simplify morale details init code a bit
b4c616f
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Share morale init code between atk & def groups
5d2a95c
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Make sure that the input field exists
270de9d
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Create shared user data object creator
4d81c52
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Move combat techs mapping to utils
1be8827
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Use existing utils in message details creation
5a5190f
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Move morale inputs section to a component
2ca3b4c
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Move tech inputs section to a component
9599d92
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Reuse existing code to render defenses
2760c76
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Reorganise the code a bit
68a7a73
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Move unit inputs section to a component
95cb39f
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Add missing sigil
4a99965
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Add missing filter function
de6fe86
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Cleanup slot renderer
d15f4cd
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
GH-91 Start using TaskType enum
46ea4ac
@mdziekon mdziekon mentioned this issue Aug 2, 2022
Merged
5 tasks
mdziekon added a commit that referenced this issue Aug 2, 2022
@mdziekon
Merge pull request #242 from mdziekon/gh-91-simulator-refactor-02
beb2dc5 
GH-91 | Battle Simulator - Overall code refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdziekon mdziekon

Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdziekon