Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Overview pages #230

Open
mdziekon opened this issue Jul 3, 2022 · 0 comments
Open

Refactor Overview pages #230

mdziekon opened this issue Jul 3, 2022 · 0 comments
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup

Comments

@mdziekon
Copy link
Owner

mdziekon commented Jul 3, 2022

Summary

Overview file is currently at ~1.0 kLOC of messy, hard to understand and navigate code. This should be split into smaller modules, ideally "one module per functionality" kind of approach, like different pages, components and utilities.
@mdziekon mdziekon added the enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup label Jul 3, 2022
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Prepare placeholder for Overview module
3049170
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Move proxy handling to an util
0e97daf
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Refactor handleProxyDetection()
028c980
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Move referral multi account detection handling to an util
dc1738e
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Refactor handleReferralMultiAccountDetection()
3b73fa1
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Remove unused import
cf5f3b5
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Move referrer's tasks data getter to an util
e3ea5a9
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Move triggering referral task to an util
b35b26c
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Move dump creator to an util
ab5ddc1
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Move user updates to an util
eaf2305
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Modernize & fix welcome message rendering
231b6ca
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Move FirstLogin screen completely to its own module place
4660d8f
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Move effects to their own function
85e022c
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
GH-230 Move adding free premium to its own util
18b0b82
@mdziekon mdziekon mentioned this issue Jul 3, 2022
Merged
3 tasks
mdziekon added a commit that referenced this issue Jul 3, 2022
@mdziekon
Merge pull request #232 from mdziekon/gh-230-first-login-refactor
35cfd8a 
GH-230 | Overview - First Login screen refactors
mdziekon added a commit that referenced this issue Jul 4, 2022
@mdziekon
GH-230 Move planet name validator & error mappers to utils
a5b523b
mdziekon added a commit that referenced this issue Jul 4, 2022
@mdziekon
GH-230 Create galaxy (planet link) routing helper
a534f6c
mdziekon added a commit that referenced this issue Jul 4, 2022
@mdziekon
GH-230 Create GalaxyPlanetLink component
5fdf2c0
mdziekon added a commit that referenced this issue Jul 4, 2022
@mdziekon
GH-230 Start using GalaxyPlanetLink component
84942ce
mdziekon added a commit that referenced this issue Jul 4, 2022
@mdziekon
GH-230 Remove unused file
a2d261d
mdziekon added a commit that referenced this issue Jul 4, 2022
@mdziekon
GH-230 Move Planet name change screen's code completely to its submodule
41cbccf
@mdziekon mdziekon mentioned this issue Jul 4, 2022
Merged
2 tasks
mdziekon added a commit that referenced this issue Jul 4, 2022
@mdziekon
Merge pull request #233 from mdziekon/gh-230-planet-name-change-refactor
ccf1db0 
GH-230 | Overview - Planet name change screen refactor
mdziekon added a commit that referenced this issue Jul 6, 2022
@mdziekon
GH-230 Move colonization task handling to an util
97b485b
@mdziekon mdziekon mentioned this issue Jul 6, 2022
Merged
3 tasks
mdziekon added a commit that referenced this issue Jul 6, 2022
@mdziekon
Merge pull request #235 from mdziekon/gh-230-overview-components-refa…
4687ac7 
…ctor

GH-230 | Overview - Planets list summary refactor
mdziekon added a commit that referenced this issue Jul 7, 2022
@mdziekon
GH-230 Move quick transport rendering to a separate component
f05f60f
mdziekon added a commit that referenced this issue Jul 7, 2022
@mdziekon
GH-230 Use existing functions to sum all resources
a11d186
mdziekon added a commit that referenced this issue Jul 7, 2022
@mdziekon
GH-230 Move stats list to a component
6b5e663
@mdziekon mdziekon mentioned this issue Jul 7, 2022
Merged
4 tasks
mdziekon added a commit that referenced this issue Jul 7, 2022
@mdziekon
Merge pull request #236 from mdziekon/gh-230-res-transport-component
b20e0a2 
GH-230 | Overview - Quick Transport & Stats list refactor
mdziekon added a commit that referenced this issue Jul 11, 2022
@mdziekon
GH-230 Move entire admin info box to a component
f511993
mdziekon added a commit that referenced this issue Jul 11, 2022
@mdziekon
GH-230 Use constants for alert types
785ab10
mdziekon added a commit that referenced this issue Jul 11, 2022
@mdziekon
GH-230 Move entire email change info box to a component
530a04e
mdziekon added a commit that referenced this issue Jul 11, 2022
@mdziekon
GH-230 Fix typo in polish translation of email change process
f61692f
mdziekon added a commit that referenced this issue Jul 11, 2022
@mdziekon
GH-230 Move new messages counter to a component
54ac6eb
mdziekon added a commit that referenced this issue Jul 11, 2022
@mdziekon
GH-230 Remove unnecessary merge with $_Lang
6bb13aa
mdziekon added a commit that referenced this issue Jul 11, 2022
@mdziekon
GH-230 Move new surveys counter to a component
78137dd
mdziekon added a commit that referenced this issue Jul 11, 2022
@mdziekon
GH-230 Minor translation fix
c9c0d1b
@mdziekon mdziekon mentioned this issue Jul 11, 2022
Merged
5 tasks
mdziekon added a commit that referenced this issue Jul 11, 2022
@mdziekon
Merge pull request #238 from mdziekon/gh-230-alert-components
59bf5a7 
GH-230 | Overview - Alert components (part 1)
mdziekon added a commit that referenced this issue Jul 17, 2022
@mdziekon
GH-230 Move morale rendering code to own component
7ec348b
mdziekon added a commit that referenced this issue Jul 17, 2022
@mdziekon
GH-230 Move vacation box to its own component
ef2c939
mdziekon added a commit that referenced this issue Jul 17, 2022
@mdziekon
GH-230 Move account activation info box to own component
de2ef2f
mdziekon added a commit that referenced this issue Jul 17, 2022
@mdziekon
GH-230 Move noob protection infobox & effects into own component
c050b3c
mdziekon added a commit that referenced this issue Jul 17, 2022
@mdziekon
GH-230 Move gift items infobox to its own component
f46dee6
mdziekon added a commit that referenced this issue Jul 17, 2022
@mdziekon
GH-230 Minor translation fixes for gifted items
036f7de
mdziekon added a commit that referenced this issue Jul 17, 2022
@mdziekon
GH-230 Move feedback messages to their own component
d46de52
mdziekon added a commit that referenced this issue Jul 17, 2022
@mdziekon
GH-230 Move combat stats to own component
ce3c8f3
mdziekon added a commit that referenced this issue Jul 17, 2022
@mdziekon
GH-230 Move combat stats data fetcher to utils
169d22d
mdziekon added a commit that referenced this issue Jul 17, 2022
@mdziekon
GH-230 Move game stats data fetcher to utils as well
8bd6ce3
@mdziekon mdziekon mentioned this issue Jul 17, 2022
Merged
6 tasks
mdziekon added a commit that referenced this issue Jul 17, 2022
@mdziekon
Merge pull request #240 from mdziekon/gh-230-more-overview-components
d995eac 
GH-230 | Overview - Various components refactor (part 1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdziekon