Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor user settings #224

Open
mdziekon opened this issue Jun 8, 2022 · 0 comments
Open

Refactor user settings #224

mdziekon opened this issue Jun 8, 2022 · 0 comments
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup

Comments

@mdziekon
Copy link
Owner

mdziekon commented Jun 8, 2022

Summary

User settings management file is currently at ~1.5 kLOC of messy, hard to understand and navigate code. This should be split into smaller modules, ideally "one module per functionality" kind of approach.
@mdziekon mdziekon added the enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup label Jun 8, 2022
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Prepare settings module folders
610d93c
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move password change validation into utils
c3a5dfb
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Clear session using existing function
982c377
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move email change validation into utils
24bf057
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move banned domain checker to a common function
a962a4c
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Modernise the code a bit
3d1b374
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Fix email title & content translations
a7a05a7
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move email address taken fetcher to an util
ff6f74c
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move email address process entry creator to an util
a8d71ee
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move email content creator to an util
388c906
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move resources ordering validation to an util
539f51b
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move moving fleets counter fetcher to an util
1cf6817
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move vacation enabling checks to an util
989f352
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move ignore user checks to an util
1f4ace5
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move ignore entry creator to an util
3373363
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move ignore entries remover to an util
529315d
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move delete ignore entries input normalization to an util
3ac4e2f
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move actual unsetting of ignore entries to the effect
8510c0d
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move deleting ignore entries validation to an util
462074f
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move fetching ignored users to an util
447da81
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Do not store ignored users in $_User in-memory store for no re…
7ccd2bc 
…ason
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move login history fetcher to an util
0557864
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move login entry rendering into a component
a9768e6
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move username change validator to an util
7399d78
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Use existing util to kill session
5f0f569
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move username change entry creator to an util
783a0c6
mdziekon added a commit that referenced this issue Jun 21, 2022
@mdziekon
GH-224 Move user updater to utils
b0899bc
mdziekon added a commit that referenced this issue Jun 24, 2022
@mdziekon
GH-224 Move username change screen code to Screen
cc9dd39
mdziekon added a commit that referenced this issue Jun 24, 2022
@mdziekon
GH-224 Move username change mode up in the code
385d73f
mdziekon added a commit that referenced this issue Jun 24, 2022
@mdziekon
GH-224 Allow to get min vacation duration as a number
99dfb87
mdziekon added a commit that referenced this issue Jun 24, 2022
@mdziekon
GH-224 Do not hardcode min vacation duration
359c897
mdziekon added a commit that referenced this issue Jun 24, 2022
@mdziekon
GH-224 Fix vacation min time display (show 24-hour style time)
77cf954
@mdziekon mdziekon mentioned this issue Jun 24, 2022
Merged
4 tasks
mdziekon added a commit that referenced this issue Jun 24, 2022
@mdziekon
GH-224 Display current dark energy as green when meeting cost
44d976e
mdziekon added a commit that referenced this issue Jun 24, 2022
@mdziekon
GH-224 Reuse stored cost
2a948e3
mdziekon added a commit that referenced this issue Jun 24, 2022
@mdziekon
GH-224 Revert username change cost
9040ac9
mdziekon added a commit that referenced this issue Jun 24, 2022
@mdziekon
Merge pull request #228 from mdziekon/gh-224-simplify-nickchange-screen
44ec67b 
GH-224 | Settings - Username change screen refactor
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Move quick transport list renderer into a component
2b4475b
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Move languages selector to a component
b0bce6b
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Move rendering languages list down to at least reflect the cha…
8e35a23 
…nge faster
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Move skin related code to utils
0f8fc8b
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Move skin selector rendering to a component
2ccc823
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Move ignores users list rendering to a component
dd96fea
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Move login entries history rendering entirely to a component
884a611
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Move fleet mission colors form to a component
b5ceeeb
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Simplify marker setter
cf2412e
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Move user settings updater to an util
33279ce
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Be better about handling external URLs
a53dce5 
(transform into utils and support HTTPS)
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Do not accept protos other than http & https
15f6915
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Check if skin exists in available skins, not using disk lookup
3b30ce3
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Allow to specify root dir for lookup
982f8ba
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Reuse existing helpers to improve safety of the lookup
bc9a381
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
GH-224 Add note about potential removal of externally sourced skins
f35123e
@mdziekon mdziekon mentioned this issue Jul 1, 2022
Merged
10 tasks
mdziekon added a commit that referenced this issue Jul 1, 2022
@mdziekon
Merge pull request #229 from mdziekon/gh-224-minor-components
f2f1847 
GH-224 | Settings - Minor component refactors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdziekon