Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor galaxy rendering #208

Open
mdziekon opened this issue May 5, 2022 · 0 comments
Open

Refactor galaxy rendering #208

mdziekon opened this issue May 5, 2022 · 0 comments
Assignees
@mdziekon
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup

Comments

@mdziekon
Copy link
Owner

mdziekon commented May 5, 2022

Summary

There's a lot of repetition in all sub-renderers of the Galaxy view, can easily be shared for more concise codebase.
@mdziekon mdziekon added the enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup label May 5, 2022
@mdziekon mdziekon self-assigned this May 5, 2022
mdziekon added a commit that referenced this issue May 5, 2022
@mdziekon
GH-208 Simplify indentations of the galaxy subrenderers & share empty…
720e5e4 
… cell renderer
mdziekon added a commit that referenced this issue May 5, 2022
@mdziekon
GH-208 Simplify ShowGalaxyRows code a bit
e238dce
mdziekon added a commit that referenced this issue May 5, 2022
@mdziekon
GH-208 Simplify ShowGalaxyRows code even more
81f848e
@mdziekon mdziekon mentioned this issue May 5, 2022
Merged
3 tasks
mdziekon added a commit that referenced this issue May 5, 2022
@mdziekon
Merge pull request #209 from mdziekon/gh-208-galaxy-code-simplification
3eff335 
GH-208 | Refactor galaxy rendering | Code flattening
mdziekon added a commit that referenced this issue May 6, 2022
@mdziekon
GH-208 Remove constant planet types from args
14ece8b
mdziekon added a commit that referenced this issue May 6, 2022
@mdziekon
GH-208 Unify phalanx range checks
1040a36
mdziekon added a commit that referenced this issue May 6, 2022
@mdziekon
GH-208 Unify missile range checks
744e538
mdziekon added a commit that referenced this issue May 6, 2022
@mdziekon
GH-208 Simplify isTargetInRange by using distance comparison
980976b
mdziekon added a commit that referenced this issue May 6, 2022
@mdziekon
GH-208 Add tests for isTargetInRange
66e12d1
mdziekon added a commit that referenced this issue May 6, 2022
@mdziekon
GH-208 Code style cleanup in some of the files
1bf4794
mdziekon added a commit that referenced this issue May 6, 2022
@mdziekon
GH-208 Simplify planet's menu links rendering
b18a845
mdziekon added a commit that referenced this issue May 6, 2022
@mdziekon
GH-208 Simplify moon's menu links rendering
a4b5649
@mdziekon mdziekon mentioned this issue May 6, 2022
Merged
3 tasks
mdziekon added a commit that referenced this issue May 6, 2022
@mdziekon
Merge pull request #210 from mdziekon/gh-208-galaxy-code-refactor-01
6265a42 
GH-208 | Refactor galaxy rendering | Assorted refactors (#1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdziekon mdziekon

Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdziekon