[BUG] Returning from fleet2 to fleet1 incorrectly assumes Union has been chosen

[mdziekon]

Problem description

When going back from step 3 of the fleet control (fleet2) to the step 2 (fleet1), and there's at least one Union mission already active (experienced on self-sent Union, but probably happens on external Union's as well), step 2 will thing that our intention was to join the Union, without selecting anything.

Engine details

• Engine version:
  • version 1.1.0
  • commit 0301196
• Custom modifications:
  • Yes
  • No
• Environment:
  • local
  • testing (inaccessible from the outside)
  • production (accessible from the outside world)
• Configuration:
  • Game speeds: N/A
  • Debris settings: N/A
  • Any other relevant config entry: N/A

Steps to reproduce

Prerequisites:

• User X exists (attack sender)
• User Y exists (attack target)

Steps to reproduce the behavior:

1. Send attack on user's Y planet / moon
2. Turn that attack into a Union
3. Try to send another mission towards previously attacked planet / moon
4. When on step 3 (fleet2), go back to the previous step

Expected behavior

• Previously chosen parameters (target, speed, etc.) are preserved
• Indicator about "joining union" is not shown
• The ability to select other target (either via direct input or by selecting shortcuts) remains enabled

Actual behavior

• Previously chosen parameters (target, speed, etc.) are preserved
• Indicator about "joining union" is shown
• The ability to select other target (either via direct input or by selecting shortcuts) is disabled