Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Battle Engine (ARES) #131

Open
mdziekon opened this issue Nov 11, 2020 · 0 comments
Open

Refactor Battle Engine (ARES) #131

mdziekon opened this issue Nov 11, 2020 · 0 comments
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup

Comments

@mdziekon
Copy link
Owner

mdziekon commented Nov 11, 2020 •
edited
Loading

Summary

There's a lot of repetition in Battle Engine's code which can easily be shared for both defenders & attackers calculations. This should make it easier to modify the engine in the future.

Also, it's probably time to remove the old engines as well. Let's be honest, no one is going to adjust them to use the same interface as "ARES".
mdziekon added a commit that referenced this issue Nov 12, 2020
@mdziekon
GH-131 Share user's techs initialization code
3205e67
mdziekon added a commit that referenced this issue Nov 12, 2020
@mdziekon
GH-131 Fix rapid fire sorting for attacker
8f76338
mdziekon added a commit that referenced this issue Nov 12, 2020
@mdziekon
GH-131 Share rapid fire tables calculation code
249505b
mdziekon added a commit that referenced this issue Nov 12, 2020
@mdziekon
GH-131 Share force calculation logic
43b01f7
mdziekon added a commit that referenced this issue Nov 12, 2020
@mdziekon
GH-131 Share shield calculation logic
4271705
mdziekon added a commit that referenced this issue Nov 12, 2020
@mdziekon
GH-131 Share hull calculation logic
25754fd
mdziekon added a commit that referenced this issue Nov 12, 2020
@mdziekon
GH-131 Remove now unused globals
4e584c3
@mdziekon mdziekon mentioned this issue Nov 12, 2020
Merged
2 tasks
mdziekon added a commit that referenced this issue Nov 15, 2020
@mdziekon
GH-131 Move helper functions to separate files & namespace them
6016222
mdziekon added a commit that referenced this issue Nov 15, 2020
@mdziekon
GH-131 Fix rapid fire distribution by correctly resetting total targe…
38c1189 
…t ships counter

(now ships can utilite full rapid fire potential, because previously "left-over shots" could
have been wasted when being added to just one target user, where these shots should have been
distributed better between other users in the first place)
mdziekon added a commit that referenced this issue Nov 15, 2020
@mdziekon
GH-131 Fix incorrect hull var name for attackers' ships
b99392d
mdziekon added a commit that referenced this issue Nov 15, 2020
@mdziekon
GH-131 Move shots distribution (in group battles) code to a separate …
4db4fdd 
…util
mdziekon added a commit that referenced this issue Nov 15, 2020
@mdziekon
GH-131 Hide shield's impenetrability check in a dedicated evaluator
21572bf
mdziekon added a commit that referenced this issue Nov 15, 2020
@mdziekon
GH-131 Simplify code by using short circuit when testing shields
cf5c737
mdziekon added a commit that referenced this issue Nov 15, 2020
@mdziekon
GH-131 Minor code style fix
8a60e70
mdziekon added a commit that referenced this issue Nov 16, 2020
@mdziekon
GH-131 Move shield bypassing evaluation into its separate utility
6681b9e
mdziekon added a commit that referenced this issue Nov 16, 2020
@mdziekon
GH-131 Simplify how count of ships to destroy is calculated
bd6c9ee
mdziekon added a commit that referenced this issue Nov 16, 2020
@mdziekon
GH-131 Simplify how final phase of ships destruction calculation is p…
1ba63a2 
…erformed
mdziekon added a commit that referenced this issue Nov 16, 2020
@mdziekon
Merge pull request #132 from mdziekon/mdziekon/gh-131/battle-engine-r…
c471882 
…efactor

Refactor Battle Engine (part 1)
@mdziekon mdziekon added the enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup label Nov 16, 2020
mdziekon added a commit that referenced this issue Nov 19, 2020
@mdziekon
GH-131 Short circuit when starting rapid fire
bcc5865
mdziekon added a commit that referenced this issue Nov 19, 2020
@mdziekon
GH-131 Even more short circuiting in rapid fire
0cab175
mdziekon added a commit that referenced this issue Nov 19, 2020
@mdziekon
GH-131 Short circuit when determining rapid fire target presence
97f8748
mdziekon added a commit that referenced this issue Nov 19, 2020
@mdziekon
GH-131 Remove unused variable
bf72903
mdziekon added a commit that referenced this issue Nov 19, 2020
@mdziekon
GH-131 Short circuit in rapid fire, when there were no gained shots
3003502
@mdziekon mdziekon mentioned this issue Nov 19, 2020
Merged
1 task
mdziekon added a commit that referenced this issue Nov 19, 2020
@mdziekon
Merge pull request #133 from mdziekon/mdziekon/gh-131/battle-engine-r…
38f3653 
…efactor-part02

Refactor Battle Engine (part 2)
mdziekon added a commit that referenced this issue Nov 23, 2020
@mdziekon
GH-131 Create shields takedown calculator
30db9af
mdziekon added a commit that referenced this issue Nov 23, 2020
@mdziekon
GH-131 Use shared shield takedown calculator
0dafb74
mdziekon added a commit that referenced this issue Nov 23, 2020
@mdziekon
GH-131 Minor refactor
99ad1f0
mdziekon added a commit that referenced this issue Nov 23, 2020
@mdziekon
GH-131 Simplify calculateShieldsTakeDownStats interface
a5d00b4
mdziekon added a commit that referenced this issue Nov 23, 2020
@mdziekon
GH-131 Use calculateShieldsTakeDownStats for rapid fire pre-calculations
11eb961
mdziekon added a commit that referenced this issue Nov 23, 2020
@mdziekon
GH-131 Simplify rapid fire's shield calculation in pre-calculation phase
4e1cefe
mdziekon added a commit that referenced this issue Nov 23, 2020
@mdziekon
GH-131 Simplify rapid fire's hull calculation in pre-calculation phase
a69e36b
mdziekon added a commit that referenced this issue Nov 23, 2020
@mdziekon
GH-131 Simplify rapid fire's minimal shots calculation in pre-calcula…
3119182 
…tion phase
@mdziekon mdziekon mentioned this issue Nov 23, 2020
Merged
1 task
mdziekon added a commit that referenced this issue Nov 23, 2020
@mdziekon
GH-131 Fix incorrect index usage
5ab0139
mdziekon added a commit that referenced this issue Nov 23, 2020
@mdziekon
GH-131 Calculate targets remaining only once
8ec7676
mdziekon added a commit that referenced this issue Nov 23, 2020
@mdziekon
GH-131 Simplify code's indentation a bit
2758282
mdziekon added a commit that referenced this issue Nov 23, 2020
@mdziekon
Merge pull request #136 from mdziekon/mdziekon/gh-131/battle-engine-r…
5ab6c0a 
…efactor-part03

Refactor Battle Engine (part 3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement_request All issues containing enhancements proposals to the existing functionalities, codebase or dev setup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdziekon