Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra semicolons in web-share example #277

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix: remove extra semicolons in web-share example #277

merged 1 commit into from
Aug 22, 2024

Conversation

joshkadis
Copy link
Contributor

@joshkadis joshkadis commented Jul 23, 2024

@pepelsbey @mrienstra I noticed a small bug that was introduced in #227. There are a couple of places where a semicolon comes after a function argument, which makes the code invalid. Easiest to show from linting:

Screenshot 2024-07-23 at 3 05 56 PM

@joshkadis joshkadis requested a review from a team as a code owner July 23, 2024 19:08
@joshkadis joshkadis requested review from pepelsbey and removed request for a team July 23, 2024 19:08
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch! Thank you :)

@pepelsbey pepelsbey merged commit 08dadaa into mdn:main Aug 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants