Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebAssembly] Ship exnref #35696

Closed
7 of 8 tasks
Tracked by #574
Rumyra opened this issue Sep 2, 2024 · 4 comments
Closed
7 of 8 tasks
Tracked by #574

[WebAssembly] Ship exnref #35696

Rumyra opened this issue Sep 2, 2024 · 4 comments

Comments

@Rumyra
Copy link
Collaborator

Rumyra commented Sep 2, 2024

Acceptance criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes for enabled/preview features
  • Add/remove entry to Firefox experimental features page for preference/released features

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=1908375

Other

  • Check content open issues to see if any pertain to the subject matter. If there are any that can be closed because of the work, do so. If there are any that can be fixed relatively quickly because of the knowledge from completing this issue and you have time, feel free to go ahead and fix them.
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Sep 2, 2024
@Rumyra Rumyra added Content:wasm WebAssembly docs Firefox 131 and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Sep 2, 2024
@Rumyra Rumyra moved this from Backlog to Todo in MDN Web Docs Content Team Sep 2, 2024
@Rumyra Rumyra added this to the Firefox 131: Due Oct 1st milestone Sep 3, 2024
@hamishwillee
Copy link
Collaborator

hamishwillee commented Sep 30, 2024

Note, I have NOT assigned this to me. It is probably going to be horrible and time consuming, and IMO not a high priority for the majority of MDN readers. I will take it if no one else does, but deal with it over time.

I don't understand how references work in WASM and our docs don't help. I'm seeking help in WebAssembly/exception-handling#280 (comment) https://bugzilla.mozilla.org/show_bug.cgi?id=1908375#c5 .

  • BCD - na
  • Docs - na
  • Release note
  • dev-docs-complete

@dletorey
Copy link
Contributor

dletorey commented Oct 1, 2024

PRs

@eqrion
Copy link

eqrion commented Oct 2, 2024

@hamishwillee Hi Hamish. The 'exnref' (and exception-handling feature in general) are intended to be used inside wasm functions for making source language (e.g. C++ try/catch/finally) exception handling work on the web. It does this using some new value types and instructions that can be used inside a wasm module.

Looking over our existing MDN docs, there is no pre-existing reference on value types/instructions. The closest is this walkthrough on creating a wasm module using the text format (https://developer.mozilla.org/en-US/docs/WebAssembly/Understanding_the_text_format#exploring_fundamentals).

I don't think it makes sense to expand the walkthrough with this new types, as that would defeat the purpose of an overview. This new feature really would need to be part of some reference on wasm instructions, which MDN doesn't have. Adding one would be neat, but a ton of work, and also sort of niche (most web developers will get a compiled wasm from a compiler, not hand write one). So I'd think we probably don't need to extend MDN for this wasm feature.

@hamishwillee
Copy link
Collaborator

Thanks @eqrion - very happy to take this as "no further work" for the reasons you have given!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Archive
Development

No branches or pull requests

4 participants