BUG. In rearrange, modal X (close) causes problems

[thundor]

FIX: in dialog.js
AFTER:

if ((typeof afterHide !== 'undefined')) {
	Y.soon(function() {
		afterHide(parent);
	});
}

Add this:
parent.close();

When rearranging, when clicking the X button on the dialog (close dialog), the modal element is not deleted but rather hidden, causing problems on the next modal open, (the colour field is not rendered correctly, opening another field a second time and saving breaks the field).

[carlicockrell]

Hello,

I work for Moodle as a Learning Designer consultant, and I believe we witnessed something interesting because of this bug. We noticed this same behavior, but it also completely renamed/chose different dynamic fields for the positional elements. For example, we had 5 different course custom fields, and each had a different name, such as eitp_1, eitp_2, etc. After working on the repositioning, all of the custom fields pointed to the same thing, and had all renamed to eitp_1. It was pretty strange behavior and caused us to have to start the certificate over because any adjustments we attempted after that would not save properly.

[mdjnelson]

Thanks @thundor, are you able to create a PR for this?

[thundor]

Thanks @thundor, are you able to create a PR for this?

Sorry, i never done it and i'm too cramped with work to learn this now