Plans.create has incorrect parameters #40
Comments
stewSquared
changed the title
product
|
I should note that the rest of the Plans API looks really good. Thanks a lot! This library is saving me a ton of trouble. |
|
Neither @mdedetrich or myself are actively adding features to this library but we would welcome pull requests with tests. There are already quite a few unit/integration tests around so just copy what you see there. |
|
@leonardehrenfried Sure thing! I don't think it's too much effort to provide fixes myself. |
|
I usually review within 1 or 2 days.
Matthew cuts the releases in the end and sometimes needs a little more
prodding but it shouldn't be more than a few days.
Am 16.03.2018 11:23 schrieb "Stewart Stewart" <[email protected]>:
… @leonardehrenfried <https://github.com/leonardehrenfried> Sure thing! I
don't think it's too much effort to provide fixes myself.
How actively are you two reviewing PRs and cutting releases? I've found a
couple more subtle bugs since I posted the issue last night.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJPMiuE8YQldQ0cvKnS3erIUc_VwGr2ks5te5KqgaJpZM4StJ3M>
.
|
|
If you submit a PR I can easily review and merge. |
|
@mdedetrich @leonardehrenfried |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've noticed a few issues with the createPlan implementation:A recent Major change in the Stripe API breaks the current Plans implementation:
(1) We're missing the
productparameter. From https://stripe.com/docs/api/java#create_plan-product:In this implementation, product is missing from both the
PlanandPlanInputcase classes.(2) The
namefield is incorrectly encoded. I'm assuming thenameparameter was supposed to be used as the plan's optionalnicknameas opposed to the product's requiredname. If that's so, the spelling of this field is another bug. In the other case, it's still a bug since it's not a required field nested under the (missing)productobject.(3)
trial_period_daysis not a parameter for creating plans, though it is present in the returned json. Rather, it's a paremeter when creating subscriptions to existing plans.The text was updated successfully, but these errors were encountered: