Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan listing tries to fetch customer #38

Open
mkoppanen opened this issue Aug 19, 2017 · 3 comments
Open

Plan listing tries to fetch customer #38

mkoppanen opened this issue Aug 19, 2017 · 3 comments

Comments

@mkoppanen
Copy link

Looks like there is a possible copy-paste error in plans:

https://github.com/mdedetrich/stripe-scala/blob/master/src/main/scala/org/mdedetrich/stripe/v1/Plans.scala#L317

@leonardehrenfried
Copy link
Collaborator

Ok, I fixed this in master.

Plans aren't really covered by integration tests, so if you want to contribute one, it'd be very appreciated.

@mdedetrich Can you release a new version?

@mkoppanen
Copy link
Author

@leonardehrenfried,

I am currently testing the following locally: mkoppanen@96f7918

It does look like SubscriptionUpdateInput is not actually necessary as SubscriptionInput could be used.

In my use-case I assign everyone to a subscription, which is "Free Plan" for new users. As they (hopefully) convert into paying users I update the existing subscription to a new plan. In case they are paying and and upgrade the prorating kicks in.

I'll create some unit tests for plans and subscriptions and contribute back.

@stewSquared
Copy link

@mkoppanen Hi there! I was just adding some fixes for Plans (#41).
Are you still working on adding unit tests for plans and subscriptions? I'd like to piggy back off of your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants