-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update adapters to reflect the latest changes in the beacon schema #70
Comments
I'd like to take a crack at updating the nodejs adapter. I'm having trouble getting the project running, so this is a tentative dibs. |
@alexwweston: what problems are you facing in setting up the project, can you post some screenshots? |
I created this gist which shows the issues I'm running into: https://gist.github.com/alexwweston/8dd626fe8cb01fd9a036 Let's move the conversation there to keep this issue clean. |
@alexwweston In which directory did you run the command? |
I can now run the node rest adapter with no issues, and I have some idea of the changes I will need to make. My question is this: do you have any suggestions for testing changes to the adapter as I go (right now I'm just talking about manual tests)? The only way I can think of is to set up a local bob with some data, but I'm curious if anyone else has ideas. I generally don't like to make any changes unless I have some way to test them. |
Well, the adapter does not serve any data, it's merely a template generating sample output in the format which should be compatible with the Avro file. I guess the test here is making sure the format matches what is prescribed by the Avro file (manually), there is very little functionality to test in the adapter itself. I know what you mean though, but we don't have anything better right now. If you have a look at #51, it links a document which explains what the adapter exposes right now - maybe this example can help. |
Node.js adapter updated (thanks @alexwweston), Java and Python ones pending. |
Adapters: https://github.com/mcupak/beacon-of-beacons/tree/master/beacon-adapters
Schema: https://github.com/ga4gh/schemas/blob/master/src/main/resources/avro/beacon.avdl
Note the change in query parameters.
The text was updated successfully, but these errors were encountered: