Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adapters to reflect the latest changes in the beacon schema #70

Open
mcupak opened this issue Mar 20, 2015 · 7 comments
Open

Update adapters to reflect the latest changes in the beacon schema #70

mcupak opened this issue Mar 20, 2015 · 7 comments

Comments

@mcupak
Copy link
Owner

mcupak commented Mar 20, 2015

Adapters: https://github.com/mcupak/beacon-of-beacons/tree/master/beacon-adapters
Schema: https://github.com/ga4gh/schemas/blob/master/src/main/resources/avro/beacon.avdl

Note the change in query parameters.

@alexwweston
Copy link
Contributor

I'd like to take a crack at updating the nodejs adapter. I'm having trouble getting the project running, so this is a tentative dibs.

@rohankatyal29
Copy link
Contributor

@alexwweston: what problems are you facing in setting up the project, can you post some screenshots?

@alexwweston
Copy link
Contributor

I created this gist which shows the issues I'm running into: https://gist.github.com/alexwweston/8dd626fe8cb01fd9a036

Let's move the conversation there to keep this issue clean.

@rishabhsethi
Copy link

@alexwweston In which directory did you run the command?
Try executing the command inside one of the modules.

@alexwweston
Copy link
Contributor

I can now run the node rest adapter with no issues, and I have some idea of the changes I will need to make. My question is this: do you have any suggestions for testing changes to the adapter as I go (right now I'm just talking about manual tests)? The only way I can think of is to set up a local bob with some data, but I'm curious if anyone else has ideas. I generally don't like to make any changes unless I have some way to test them.

@mcupak
Copy link
Owner Author

mcupak commented Mar 30, 2015

Well, the adapter does not serve any data, it's merely a template generating sample output in the format which should be compatible with the Avro file. I guess the test here is making sure the format matches what is prescribed by the Avro file (manually), there is very little functionality to test in the adapter itself. I know what you mean though, but we don't have anything better right now.

If you have a look at #51, it links a document which explains what the adapter exposes right now - maybe this example can help.

@mcupak
Copy link
Owner Author

mcupak commented Apr 8, 2015

Node.js adapter updated (thanks @alexwweston), Java and Python ones pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants