Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting an instance in the menu then trying to install a mod causes glitchy partial instance switching #44

Open
Valiec opened this issue Aug 12, 2017 · 2 comments
Labels

Comments

@Valiec
Copy link
Contributor

Valiec commented Aug 12, 2017

The issue is that if you have an instance selected (i.e. active) (I'll call it "InstanceA"), and you select another instance (I'll call it "InstanceB") in the menu but not actually select it with the select instance button, then install a mod, the mod list shown changes to match InstanceB, but the compatibility check still seems to use InstanceA.

There are probably other issues regarding this, but I haven't tested it further.

@williambl
Copy link
Member

Perhaps we should do away with the select instance button and just have it change the instance when you select it in the dropdown? It seems more intuitive - the instance displayed is the instance selected.

@williambl williambl added the bug label Aug 12, 2017
@Valiec
Copy link
Contributor Author

Valiec commented Aug 14, 2017

I've thought about that, but it would cause troubles for removing instances, since you currently cannot remove the current active instance.

A solution would be to allow you to remove the current active instance, but not the instance set as default, which will then be selected when the current instance is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants