Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we handle different versions of the same mod? #5

Open
williambl opened this issue Jul 22, 2017 · 4 comments
Open

How do we handle different versions of the same mod? #5

williambl opened this issue Jul 22, 2017 · 4 comments

Comments

@williambl
Copy link
Member

williambl commented Jul 22, 2017

Currently, for Forge, we just have different versions using their own JSONs. But this seems a bit annoying - perhaps we could instead have a generic JSON, such as this:

{
    "Name":"MinecraftForge",
    "Link":"http://files.minecraftforge.net/maven/net/minecraftforge/forge/<mc-version>-<version>/forge-<mc-version>-<version>-installer.jar",
    "Author":"github.com/MinecraftForge/",
    "Desc":" Modifications to the Minecraft base files to assist in compatibility between mods.",
    "License":"MinecraftForgePublicLicence",
    "Requirements":[],
    "Incompatibilities":[],
    "Recommended":[],
    "Type":"Installer",
    "Unstable":"false",
    "InstallerName":"Forgeinstaller"
}

and then have other JSONs which just look like this:

{
    "Version":"13.20.1.2386",
    "MCVersion":["1.11.2"]

}

How does that sound to everyone?

@lewisakura
Copy link

wew just remembered that this was a thing.

Yeah, seems to be a nice format.

@williambl
Copy link
Member Author

OK, I'm working on it in the new-syntax branch.

@williambl
Copy link
Member Author

I'm going to change it again so that each version has its own link instead of formatting an existing link - this is to make links to curse, which uses seemingly random numbers to differentiate versions, compatible.

@Valiec
Copy link
Contributor

Valiec commented Jul 12, 2019

Curse has different dependencies for different versions, that'll need to be added too (I'll handle it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants