Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Arduino_LoRaWAN.h - kCountryCode() #200

Open
matthias-bs opened this issue Jun 19, 2022 · 0 comments
Open

Bug in Arduino_LoRaWAN.h - kCountryCode() #200

matthias-bs opened this issue Jun 19, 2022 · 0 comments

Comments

@matthias-bs
Copy link
Contributor

        // return the country code
        constexpr uint16_t kCountryCode(char c1, char c2)
                {
                return (c1 < 'A' || c1 > 'Z' || c2 < 'A' || c2 > 'Z')
                        ? 0
                        : ((c1 << 8) | c1);
                }

The last part of the return value should probably read

((c1 << 8) | c2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant