Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx official image #87

Open
Glideh opened this issue Jan 12, 2018 · 1 comment
Open

Nginx official image #87

Glideh opened this issue Jan 12, 2018 · 1 comment

Comments

@Glideh
Copy link

Glideh commented Jan 12, 2018

Shouldn't we use the official nginx image instead of building one from debian:jessie ?
We could use something like:

services:
# ...
  nginx:
    image: nginx:1.13
    depends_on:
      - php
    volumes:
      - ${SYMFONY_APP_PATH}/web/:/var/www/symfony/web
      - ./logs/nginx:/var/logs/nginx
      - ./symfony.conf:/etc/nginx/conf.d/default.conf
# ...

No Dockerfile is even needed for the service

@maxpou
Copy link
Owner

maxpou commented Jan 28, 2018

Hi,
Your proposal looks good :)
Feel free to open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants