You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In arbitrage.observers.traderbot.TraderBot#end_opportunity_finder
def end_opportunity_finder(self):
if not self.potential_trades:
return
self.potential_trades.sort(key=lambda x: x[0])
# Execute only the best (more profitable)
self.execute_trade(*self.potential_trades[0][1:])
potential_trades sort by profit and use 0 index not -1
Why choice the most lowest profit params to trade ?
And I think we should find the max_volume to trade before calculate profit not in the opportunity method in TraderBot . I think the profit will more real and make sence.
The text was updated successfully, but these errors were encountered:
631068264
changed the title
Sth strange by potential_trades sort
Sth strange by potential_trades sort and TraderBot
Jul 19, 2018
In
arbitrage.observers.traderbot.TraderBot#end_opportunity_finder
potential_trades sort by profit and use
0
index not-1
Why choice the most lowest profit params to trade ?
And I think we should find the
max_volume
to trade before calculate profit not in theopportunity
method inTraderBot
. I think the profit will more real and make sence.The text was updated successfully, but these errors were encountered: