Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sth strange by potential_trades sort and TraderBot #55

Open
631068264 opened this issue Jul 19, 2018 · 0 comments
Open

Sth strange by potential_trades sort and TraderBot #55

631068264 opened this issue Jul 19, 2018 · 0 comments

Comments

@631068264
Copy link

631068264 commented Jul 19, 2018

In arbitrage.observers.traderbot.TraderBot#end_opportunity_finder

def end_opportunity_finder(self):
    if not self.potential_trades:
        return
    self.potential_trades.sort(key=lambda x: x[0])
    # Execute only the best (more profitable)
    self.execute_trade(*self.potential_trades[0][1:])

potential_trades sort by profit and use 0 index not -1
Why choice the most lowest profit params to trade ?

And I think we should find the max_volume to trade before calculate profit not in the opportunity method in TraderBot . I think the profit will more real and make sence.

@631068264 631068264 changed the title Sth strange by potential_trades sort Sth strange by potential_trades sort and TraderBot Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant