Make spec tests pass

[EmersonPrado]

Currently, running rake spec in branch 'develop' yields an enormous amount of errors:

$ rake spec | grep failures
...
74 examples, 73 failures

It seems many of them are caused by missing facts and variables and misformed resources in the spec tests themselves, rather than errors in the classes and defined types.

[EmersonPrado]

I started with varnish::acl spec test, which had the least failures (2) and didn't include other classes/defines. So far, this made this define pass spec test, preserving all tests.

[EmersonPrado]

varnish::ncsa spec tests corrected too

[EmersonPrado]

varnish::vcl tests corrected and varnish::selector and varnish::service tests partially corrected. Now failure count is 54.

[EmersonPrado]

Went thru all tests I could improve without losing any test functionality or changing module logic. Well, there were two changes: I had to add a include varnish::service in class varnish::shmlog and changing a variable interpolation for the variable itself in template varnish-conf.erb (I chose to correct the template instead of the spec test because this made the template coherent with the Varnish defaults).

Now there are 25 failures, so distributed:

• Class varnish => 2 failures
• Class varnish::repo => 8 failures
• Defined type varnish::selector => 6 failures
• Class varnish::service => 6 failures
• Class varnish::shmlog => 3 failures

All of them are repetitions of:

1. Classes varnish::shmlog, varnish::service and varnish::repo => Unknown variable: 'varnish::real_version' at ...modules/varnish/manifests/repo.pp:59:15
2. Defined type varnish::selector => Repo version 50 not supported at ...modules/varnish/manifests/repo.pp:59:15
3. Class varnish => ...expected that the catalogue would contain File[varnish-conf] with notify set to "Service[varnish]" but it is set to Exec[restart-varnish]{:command=>"restart-varnish"}

The first one can be fixed by including class varnish in affected classes, but this causes a duplicate resource declaration for the class itself. There should be a better way of passing this variable to the dependent classes.
For the repo version not supported, the spec test asks for version 5.0, but class varnish::repo doesn't provide a key_id for this. In my understanding, the fix depends on the module intention: if it should configure Debian with Varnish 5.0, then the key should be included in class varnish::repo, otherwise the spec test should test for a supported repo version.
For the file resource notify parameter for the third failure, I have no idea if this is a real failure in varnish class - File['varnish-conf'] should notify Service[varnish] - or a false positive - File['varnish-conf'] should notify Exec['restart-varnish'].

@maxchk , would you mind shedding me some light about failures 2 and 3? I guess the first one is bigger than the intent of this issue, but the other two should be rather simple - once I know what they should be.