Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service enable not set for varnish #140

Open
tobixen opened this issue Feb 28, 2017 · 5 comments
Open

service enable not set for varnish #140

tobixen opened this issue Feb 28, 2017 · 5 comments

Comments

@tobixen
Copy link
Contributor

tobixen commented Feb 28, 2017

The current (master) manifests apparently sets this as default:

service {'varnish':
  ensure => running;
}

this will cause puppet to start up varnish if it's not already running - but it's not good enough, our new varnish VM did not pass the reboot test. Ref https://docs.puppet.com/puppet/4.9/types/service.html enable should also be set:

service {'varnish':
  ensure => running,
  enable => true;
}

As for now I simply did a "systemctl enable varnish" on the server, it may be that I'll write up a pull request at a later stage if I get to it.

@kwisatz
Copy link
Contributor

kwisatz commented Aug 8, 2017

Please do, I ran into the same problem just now. I'm just not sure why it suddenly appeared with an upgrade from puppet 3.7.2 to 3.8.7, but has not gone away with a downgrade…

@kwisatz
Copy link
Contributor

kwisatz commented Aug 8, 2017

Nope, my problem doesn't seem to be related to this. I'll create a new ticket.

@func0der
Copy link

func0der commented Sep 4, 2017

@maxchk Close this, pls. Too many open issues let the module look bad.

@tobixen
Copy link
Contributor Author

tobixen commented Sep 4, 2017

I still believe this is a real issue. The fix is very simple though.

@EmersonPrado
Copy link

Let's fix it. Added PR 158.

maxchk added a commit that referenced this issue Sep 28, 2017
[Issue #140] Add "enable" parameter for varnish service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants