Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian jessie and systemd Environment file #125

Open
traskat opened this issue Nov 22, 2016 · 3 comments
Open

Debian jessie and systemd Environment file #125

traskat opened this issue Nov 22, 2016 · 3 comments

Comments

@traskat
Copy link

traskat commented Nov 22, 2016

Hi,

the params file doesn't handle Debian jessie with varnish 4. The environment file is wrong in the systemd environment file config.

@kwisatz
Copy link
Contributor

kwisatz commented Nov 24, 2016

True, indeed:

# Note: If systemd is installed, this file is obsolete and ignored.  You will
# need to copy /lib/systemd/system/varnish.service to /etc/systemd/system/ and
# edit that file.

https://github.com/maxchk/puppet-varnish/blob/develop/manifests/service.pp does handle service restart (though we might want to replace the /etc/init.d calls with service calls as well for debian > 7), but it does not take care of configuration. The template (https://github.com/maxchk/puppet-varnish/blob/develop/templates/varnish.service.erb) is almost devoid of configuration related variables.

@traskat Would you be willing to create a pull request for this and, if not, could you post an example of a modified service file to see which options are most likely to be modified?

@traskat
Copy link
Author

traskat commented Dec 14, 2016

@kwisatz
will create a pull request in the next couple of days.

i thought about to add a conditional to the template or something like that

@EmersonPrado
Copy link

Would Issue #145 affect this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants