Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release CI #274

Open
patrickelectric opened this issue Aug 26, 2024 · 5 comments
Open

Fix release CI #274

patrickelectric opened this issue Aug 26, 2024 · 5 comments

Comments

@patrickelectric
Copy link
Member

At the moment release CI is broken, it appears that some necessary changes in cargo-workspaces is still not available to allow deployment of multiple crates in an workspace. It's necessary for us to come up with a solution meanwhile.

@pv42
Copy link
Contributor

pv42 commented Aug 26, 2024

As I understand the problem is that crate-interdepence via paths is not allowed on crates.io while using versions breaks tests that depend on changes ahead of the latest release.
Is there anything preventing the use of both at the same time ?

@patrickelectric
Copy link
Member Author

As I understand the problem is that crate-interdepence via paths is not allowed on crates.io while using versions breaks tests that depend on changes ahead of the latest release. Is there anything preventing the use of both at the same time ?

How do you suggest to have both simultaneously ? The release should be an automatic operation.

@pv42
Copy link
Contributor

pv42 commented Aug 26, 2024

Like this (this is a dev dependency but should be the same)
https://github.com/tokio-rs/tokio/blob/1ac8dff213937088616dc84de9adc92b4b68c49a/tokio-macros/Cargo.toml#L30

tokio = { version = "1.0.0", path = "../tokio", features = ["full"] }

@joaoantoniocardoso
Copy link
Contributor

If it helps to know, tokio uses workspaces resolver = "2"

@pv42
Copy link
Contributor

pv42 commented Aug 26, 2024

I don't think the resolver matters since the change seems to be mostly about features.
Anyways here is a workspace on resolver 1 (since it is edition 2018) that uses it: hdf5 Accidentally linked a fork from this hdf5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants