Android support for serial/bluetooth disabling #10763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just checked this. It is really cool what you did to modify the androidManifest searching for those comments. I didn't know that could be done on the *.pri files. I love it! Looks great to me, Thanks! |
Davidsastresas
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QGC has build settings to disable serial port and bluetooth support. The android build was not correctly supporting these settings which respect to updating the AndroidManifest.xml correctly. This is now fixed.
This change was driven by fixing up upstream qgc for Herelink support in ways which require less upstream changes to get a Herelink build to work. In this specific case Herelink does not support usb (serial) or bluetooth.