Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rain data missed. Propose to consider yearly-monthly-weekly-daily #106

Open
ThomDietrich opened this issue Jul 30, 2022 · 0 comments
Open

Comments

@ThomDietrich
Copy link
Contributor

ThomDietrich commented Jul 30, 2022

Hey there,

I'm experiencing an issue with missed rain data.

Example for measurements reported to the observer driver:

GET /weatherstation/updateweatherstation.php?ID=xxx&PASSWORD=xxx&indoortempf=75.2&tempf=71.4&dewptf=61.2&windchillf=71.4&indoorhumidity=62&humidity=70&windspeedmph=0.9&windgustmph=2.2&winddir=34&absbaromin=29.543&baromin=29.723&rainin=0.000&dailyrainin=0.193&weeklyrainin=0.331&monthlyrainin=1.311&solarradiation=234.15&UV=2&dateutc=2022-07-30%2011:19:48&softwaretype=EasyWeatherV1.5.9&action=updateraw&realtime=1&rtfreq=5

GET /weatherstation/updateweatherstation.php?ID=xxx&PASSWORD=xxx
&indoortempf=75.2
&tempf=71.4
&dewptf=61.2
&windchillf=71.4
&indoorhumidity=62
&humidity=70
&windspeedmph=0.9
&windgustmph=2.2
&winddir=34
&absbaromin=29.543
&baromin=29.723
&rainin=0.000
&dailyrainin=0.193
&weeklyrainin=0.331
&monthlyrainin=1.311
&solarradiation=234.15
&UV=2
&dateutc=2022-07-30%2011:19:48
&softwaretype=EasyWeatherV1.5.9
&action=updateraw
&realtime=1
&rtfreq=5

Our weather station seems to provide all expected rain increments, except for yearly, which is the only one considered:

year_total = self.decode_float(data.pop('yearlyrainin', None))

This leads to missed rain when the weather station is not able to transmit its data to weewx before day's end. (This is also linked to some Wifi issues with my station, which is an unrelated issue I am currently looking into.)

The code should consider yearly, then monthly, then weekly, then daily. Do you agree? I could provide a PR if you are willing to merge it.

@ThomDietrich ThomDietrich changed the title rain yearly-monthly-weekly-daily rain data missed. Consider yearly-monthly-weekly-daily Jul 30, 2022
@ThomDietrich ThomDietrich changed the title rain data missed. Consider yearly-monthly-weekly-daily rain data missed. Propose to consider yearly-monthly-weekly-daily Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant