From 4294b87cf9478727d9b5d9100a4068179477e6e2 Mon Sep 17 00:00:00 2001 From: Hemanth Babu Date: Thu, 21 Aug 2014 15:03:05 +0530 Subject: [PATCH 1/4] Corrected syntax for specifying values for @HotReload value parameter --- owner-site/site/docs/reload.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/owner-site/site/docs/reload.md b/owner-site/site/docs/reload.md index 5b2f0aa5..a7a28eec 100644 --- a/owner-site/site/docs/reload.md +++ b/owner-site/site/docs/reload.md @@ -144,7 +144,7 @@ interface MyConfig extends Config { ... } // Will check for file changes every 500 millis. // It will use SYNC hot reload. -@HotReload(500, unit = TimeUnit.MILLISECONDS); +@HotReload(value=500, unit = TimeUnit.MILLISECONDS) @Sources("file:foo/bar/baz.properties") interface MyConfig extends Config { ... } @@ -156,7 +156,7 @@ interface MyConfig extends Config { ... } interface MyConfig extends Config { ... } // Will use ASYNC reload type and will check every 2 seconds. -@HotReload(2, type=HotReloadType.ASYNC); +@HotReload(value=2, type=HotReloadType.ASYNC); @Sources("file:foo/bar/baz.properties") interface MyConfig extends Config { ... } ``` From 46ea76f1892d6b3c9be0e1ea1adf542ff0be63db Mon Sep 17 00:00:00 2001 From: Hemanth Babu Date: Thu, 21 Aug 2014 15:15:48 +0530 Subject: [PATCH 2/4] Corrected syntax for specifying values for @HotReload value parameter --- owner-site/site/docs/reload.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/owner-site/site/docs/reload.md b/owner-site/site/docs/reload.md index a7a28eec..0177d2a9 100644 --- a/owner-site/site/docs/reload.md +++ b/owner-site/site/docs/reload.md @@ -151,12 +151,12 @@ interface MyConfig extends Config { ... } // Will use ASYNC reload type: will span a // separate thread that will check for file // changes every 5 seconds (default) -@HotReload(type=HotReloadType.ASYNC); +@HotReload(type=HotReloadType.ASYNC) @Sources("file:foo/bar/baz.properties") interface MyConfig extends Config { ... } // Will use ASYNC reload type and will check every 2 seconds. -@HotReload(value=2, type=HotReloadType.ASYNC); +@HotReload(value=2, type=HotReloadType.ASYNC) @Sources("file:foo/bar/baz.properties") interface MyConfig extends Config { ... } ``` From e2480d82f258b5762e2a1933f3c019b32040a9c3 Mon Sep 17 00:00:00 2001 From: Hemanth Babu Date: Tue, 26 Aug 2014 14:51:21 +0530 Subject: [PATCH 3/4] Since Accessible extends Config no need to specify Config Interface explicitly --- owner-site/site/docs/debugging.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/owner-site/site/docs/debugging.md b/owner-site/site/docs/debugging.md index 7434cb8a..7abfdf30 100644 --- a/owner-site/site/docs/debugging.md +++ b/owner-site/site/docs/debugging.md @@ -77,7 +77,7 @@ You can also do the same implementing the Accessible interface, that declares the `list()` methods for you: ```java -public interface SampleConfig extends Config, Accessible { +public interface SampleConfig extends Accessible { @Key("server.http.port") @DefaultValue("80") int httpPort(); From 8dbf8007da93df3829b2cad06f259dad22abb1b2 Mon Sep 17 00:00:00 2001 From: "Luigi R. Viggiano" Date: Tue, 2 Sep 2014 16:31:59 +0200 Subject: [PATCH 4/4] Revert "Since Accessible extends Config no need to specify Config Interface explicitly" This reverts commit e2480d82f258b5762e2a1933f3c019b32040a9c3. --- owner-site/site/docs/debugging.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/owner-site/site/docs/debugging.md b/owner-site/site/docs/debugging.md index 7abfdf30..7434cb8a 100644 --- a/owner-site/site/docs/debugging.md +++ b/owner-site/site/docs/debugging.md @@ -77,7 +77,7 @@ You can also do the same implementing the Accessible interface, that declares the `list()` methods for you: ```java -public interface SampleConfig extends Accessible { +public interface SampleConfig extends Config, Accessible { @Key("server.http.port") @DefaultValue("80") int httpPort();