Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Test failures on macOS (and Windows) in full-integration pipeline #3535

Closed
jfbischoff opened this issue Nov 1, 2024 · 4 comments
Closed
Labels
code sprint Possible issue(s) for the MATSim code sprint

Comments

@jfbischoff
Copy link
Collaborator

Hello,

I've noticed that the full-integration pipeline keeps on failing, not only because of some Windows tests, but also many MacOs related tests:
https://github.com/matsim-org/matsim-libs/actions/runs/11623035269
Some examples

  • SignalSystemsIT
  • RunEvExampleTest
    All of these tests run on Ubuntu.
    I'm currently looking on the Windows tests failing and will try to fix them in the next couple of days, but overall this raises some questions:
  • Do we care about these test failures? Or are we happy as long as they run on Linux?
    --> If we don't care, we should disable the pipeline, if we care, we should fix them.

Since I don't have a Mac, I can't really help with fixing - but will try to keep an eye on the Windows pipeline.

Bests,
Joschka

@jfbischoff jfbischoff changed the title Several Test failures on MacOs (and Windows) in full-integration pipeline Several Test failures on macOS (and Windows) in full-integration pipeline Nov 5, 2024
@jfbischoff
Copy link
Collaborator Author

The build is now running again on Windows, but continues to fail on macOS:
https://github.com/matsim-org/matsim-libs/actions/runs/11695784477

Is anyone with a mac willing to look into this?
@Janekdererste et al?
Probably just small things.
If not, I think it's better to disable the macos-build of all contribs rather than having it continously fail.

@Janekdererste
Copy link
Member

Sorry, I didn't have time yet. Do we still need to look into it for macOS?

@jfbischoff
Copy link
Collaborator Author

@Janekdererste : Unfortunately, yes.
Right now, there are some failing tests on windows again, but I'll look into them.

@jfbischoff jfbischoff added the code sprint Possible issue(s) for the MATSim code sprint label Nov 28, 2024
@jfbischoff
Copy link
Collaborator Author

For the time being, tests on mac-os latests have been disabled in the pipeline.
#3603

@jfbischoff jfbischoff closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code sprint Possible issue(s) for the MATSim code sprint
Projects
None yet
Development

No branches or pull requests

2 participants