Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding YNAB budget tracker #1415

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding YNAB budget tracker #1415

wants to merge 2 commits into from

Conversation

noahsphillips
Copy link

No description provided.

@tresni
Copy link
Collaborator

tresni commented Apr 7, 2020

A fellow YNABer ;) My only problem is that we haven't generally had "installer" plugins in this repository. It would be appropriate to include the .js version of your script here. It's understood that there may be dependancies to install to get a script to work.

tresni
tresni requested changes Apr 7, 2020
View reviewed changes
Copy link
Collaborator

@tresni tresni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with JS, non-installer version of your plugin to be included.

@sprak3000 sprak3000 added shell chmod chmod +x needed image update Either needs an image or a file extension bitbar bitbar tag references labels Jan 24, 2023
@sprak3000
Copy link
Collaborator

@noahsphillips

Checking in to see if you are still maintaining this plugin. If you are, these changes would need to be made:

  1. Rather than a bash script to install the plugin, the PR should be adding the actual JS plugin.
  2. The JS plugin should have the metadata tags in it, updating the names from <bitbar...> to <xbar...>.
  3. The image metadata tag needs to link to a screenshot of the plugin in action.

@sprak3000 sprak3000 removed the bitbar bitbar tag references label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tresni tresni tresni requested changes

Assignees
No one assigned
Labels
chmod chmod +x needed image update Either needs an image or a file extension shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noahsphillips @tresni @sprak3000