Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses unstable matrix endpoint /_matrix/client/unstable/im.nheko.summary/rooms/{roomId}/summary #266

Open
richvdh opened this issue Apr 26, 2022 · 6 comments

Comments

@richvdh
Copy link
Member

richvdh commented Apr 26, 2022

This endpoint appears to be something to do with MSC3266, but that MSC hasn't been accepted, so matrix.to shouldn't be using it.

@richvdh
Copy link
Member Author

richvdh commented Apr 26, 2022

more specifically: using it ties matrix.to to homeservers that choose to implement this unspecced endpoint, which is problematic.

@t3chguy
Copy link
Member

t3chguy commented Apr 26, 2022

It's the only api providing the data the service directly, the service can operate without it by falling back as below. This function acts as a proof of concept the msc needs.

The alternative is to load the full /publicRooms list from the server on every app load but that is not fit for purpose and much heavier on servers. This is what it falls back to if the api is not available.

This alternative lacks the is_space metadata which is why the delight team opted to use this msc in the first place.

@richvdh
Copy link
Member Author

richvdh commented Apr 26, 2022

Oh, good to know it's only a fallback. Thanks.

@richvdh
Copy link
Member Author

richvdh commented Apr 26, 2022

(obviously the right solution here is to finish the MSC and use the stable endpoint instead)

@clokep
Copy link
Member

clokep commented Sep 15, 2022

See also #241.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants